Send an option body with a POST request (enhanced) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST request functions now support sending a content type and a body along with the request.
Fixed formatting. Tabs to spaces (fixing previous commit).
Added mechanism to store body and content type on startRequest so they can be sent on endRequest for complex http post operations which need additional headers
Waiting for 1 second when no data is available for reading is too much and makes the communication very slow. I have reduced it to 20 miliseconds.
…the library, but still waiting and parsing responses using the library. This is useful if you need to speed up communications by sending the whole request in only one packet, as is need if you want to communicate two ESP8266 devices without endless waiting for packet ACKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use rg1220 changes to the original library so I could send a body in a post request, but I need additional headers and so I need to use beginRequest() and endRequest(). I noticed that in the rg1220 version body was not sent in these conditions because finishHeaders() was being called always with NULL as parameters from endRequest(). So I added two variables to store pointers to the body and content type char arrays so they can be used later in the case finishHeaders() is called later from outside startRequest.